Comments on: Updated version of “Bug attachment source”

By: pile0nades

pile0nades — Thu, 04 Jan 2007 03:08:11 +0000

< = <

By: pile0nades

pile0nades — Thu, 04 Jan 2007 03:03:46 +0000

Oops, comment got cut off. The fix is:

attachLink = row.cells[0].getElementsByTagName(“a”);
for(var j = 0; j < attachLink.length; j++) {
attachHref = attachLink[i].href;
if (!attachHref.match(/attachment\.cgi\?id\=\d+/))
continue;
}

By: pile0nades

pile0nades — Thu, 04 Jan 2007 03:03:00 +0000

This script doesn’t work when my Bugzilla Enhancements script is installed, because it detects the comment links it adds and fails on the attachment.cgi check. The fix is to change:

attachLink = row.cells[0].getElementsByTagName(“a”)[0];
if (!attachLink)
continue;

attachHref = attachLink.href;
if (!attachHref.match(/attachment\.cgi\?id\=\d+/))
continue;

to:

attachLink = row.cells[0].getElementsByTagName(“a”);
for(var j = 0; j

By: Dave Miller

Dave Miller — Thu, 04 Jan 2007 01:56:21 +0000

Of course, you could always HTML-escape the entire thing and put it in an HTML content type in a

block.

By: Jesse Ruderman

Jesse Ruderman — Thu, 04 Jan 2007 00:32:00 +0000

while most IE users will prefer a server-side text/plain so they can view the source in a browser window

Except that (as justdave pointed out) IE would do its bogus content sniffing and decide to parse the attachment as HTML anyway. So maybe “view-source:” is the right thing to do for IE too.

By: Jesse Ruderman

Jesse Ruderman — Wed, 03 Jan 2007 22:54:45 +0000

It might make sense to add the “source” feature to Bugzilla, or at least to Bugzilla installations used for tracking bugs in web browsers (mozilla’s, webkit’s, and opera’s). But there are browser compatibility issues: Firefox users will prefer “view-source:” for syntax highlighting, while most IE users will prefer a server-side text/plain so they can view the source in a browser window. Firefox users can take advantage of “jar:” but users of other browsers cannot.